Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testnet preview matcher #48

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

grod220
Copy link
Contributor

@grod220 grod220 commented Jun 17, 2024

Preview chainId's no longer have a hex at the end, but a number

@conorsch
Copy link
Contributor

There's been some volatility related to the chain id format on preview. The latest news is that it's mostly hex, but with an "x" prefix, see here: penumbra-zone/penumbra#4630

@grod220
Copy link
Contributor Author

grod220 commented Jun 28, 2024

Ah, helpful! Thanks, will update this.

@grod220 grod220 force-pushed the update-testnet-preview-matcher branch 2 times, most recently from eaf9a09 to dbc3097 Compare June 28, 2024 15:50
@grod220 grod220 force-pushed the update-testnet-preview-matcher branch from dbc3097 to 0b6aa06 Compare June 28, 2024 15:51
@grod220 grod220 requested a review from Valentine1898 June 28, 2024 15:52
Copy link
Contributor

@Valentine1898 Valentine1898 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grod220 grod220 merged commit 25ae9b5 into main Jun 28, 2024
6 checks passed
@grod220 grod220 deleted the update-testnet-preview-matcher branch June 28, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants