Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clobber old penumbra testnet config #72

Merged
merged 2 commits into from
Jul 30, 2024
Merged

fix: clobber old penumbra testnet config #72

merged 2 commits into from
Jul 30, 2024

Conversation

conorsch
Copy link
Contributor

During IBC dev spike, we discovered that the prax registry logic is hardcoded to pull from a penumbra-testnet-deimos-8.json, even if that's not the testnet chain id that a user is connected to.

We should update that logic, but to unblock, I'm clobbering the old config with the new config, manually, to force loading of the correct IBC channels.

@conorsch
fix: clobber old penumbra testnet config
edc2148 
During IBC dev spike, we discovered that the prax registry logic is
hardcoded to pull from a `penumbra-testnet-deimos-8.json`, even if
that's not the testnet chain id that a user is connected to.

We should update that logic, but to unblock, I'm clobbering the old
config with the new config, manually, to force loading of the correct
IBC channels.
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 47dd35a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@conorsch conorsch mentioned this pull request Jul 30, 2024
Merged
@conorsch conorsch requested a review from turbocrime July 30, 2024 20:59
@conorsch
Copy link
Contributor Author

We intentionally disable some failing tests via #73 to unblock ongoing IBC dev integration work.

@turbocrime turbocrime merged commit d8a6951 into main Jul 30, 2024
6 checks passed
@turbocrime turbocrime deleted the penumbra-testnet-rename branch July 30, 2024 21:00
conorsch added a commit that referenced this pull request Jul 30, 2024
@conorsch
chore: new penumbra devnet
5ec52b4 
As with #71 & #72, we intentionally clobber the old `deimos-8` chain
config, because that string is hardcoded in prax wallet lookups for
testnets, and we want to test without cutting intermediate releases.
@conorsch conorsch mentioned this pull request Jul 30, 2024
Merged
conorsch added a commit that referenced this pull request Jul 30, 2024
@conorsch
chore: new penumbra devnet
dbc6ef8 
Unlike with #71 & #72, where we intentionally clobbered the old `deimos-8` chain
config, I'm placing this as its own new config, because the lack of
suffix should prevent the mishandling of the lookup via the registry
URL.
conorsch added a commit that referenced this pull request Jul 30, 2024
@conorsch
chore: new penumbra devnet
6185bd6 
Unlike with #71 & #72, where we intentionally clobbered the old `deimos-8` chain
config, I'm placing this as its own new config, because the lack of
suffix should prevent the mishandling of the lookup via the registry
URL.
conorsch added a commit that referenced this pull request Jul 31, 2024
@conorsch
chore: new penumbra devnet
92737ac 
Unlike with #71 & #72, where we intentionally clobbered the old `deimos-8` chain
config, I'm placing this as its own new config, because the lack of
suffix should prevent the mishandling of the lookup via the registry
URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbocrime turbocrime Awaiting requested review from turbocrime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conorsch @turbocrime