Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add draft testnet phobos-2-x4120f355 #90

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

conorsch
Copy link
Contributor

Working on creating a long-running testnet, and the chain penumbra-testnet-phobos-2-x4120f355 is undergoing team review. As part of that review, I'm updating the prax asset registry, so that prax workflows display correct information regarding the ibc testnet assets.

@conorsch conorsch requested a review from grod220 September 12, 2024 23:24
Copy link

changeset-bot bot commented Sep 12, 2024

⚠️ No Changeset found

Latest commit: 9a6e75b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@conorsch
Copy link
Contributor Author

I fetched this info from https://testnet.plinfra.net. To prepare, I copied over the most recent testnet json file, and manually edited:

  • chain id
  • validator delegation tokens
  • counterparty channel ids for both ibc assets

The rest of the content is the same, because I didn't see any reason to update it.

Copy link
Contributor

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but looks like you still need to run cargo run to generate the registry

conorsch added a commit that referenced this pull request Sep 16, 2024
On PR #90, I forgot to run `cargo run`, but the CI check didn't catch
it, because it was only checking for changes to already committed files,
not for uncommitted files.
Working on creating a long-running testnet, and the chain `penumbra-testnet-phobos-2-x4120f355`
is undergoing team review. As part of that review, I'm updating the prax asset registry,
so that prax workflows display correct information regarding the ibc
testnet assets.
On PR #90, I forgot to run `cargo run`, but the CI check didn't catch
it, because it was only checking for changes to already committed files,
not for uncommitted files.
@conorsch
Copy link
Contributor Author

you still need to run cargo run to generate the registry

Thanks for catching. I updated the CI check so it'll fail in the future.

@conorsch conorsch merged commit 4f7e921 into main Sep 16, 2024
7 checks passed
@conorsch conorsch deleted the add-draft-testnet branch September 16, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants