Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update develop #6

Merged
merged 5 commits into from
Aug 24, 2020
Merged

update develop #6

merged 5 commits into from
Aug 24, 2020

Conversation

prayutsu
Copy link
Owner

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

rt4914 and others added 5 commits August 24, 2020 14:11
@rt4914
Fixed highfi (#1701)
ef4222f 
Co-authored-by: Rajat Talesra <talesra@google.com>
@rt4914
Fix #1656: Profile progress click fix (#1704)
67710ca 
* Initial implementation

* Nit changes

* Added test case

* Nit fix

Co-authored-by: Rajat Talesra <talesra@google.com>
@rt4914
Fix #907: Faq content highfi (#1699)
19a300f 
* Added content

* Highfi done

* Nit fixes

* Nit fix

Co-authored-by: Rajat Talesra <talesra@google.com>
@rt4914
Fix #1703: Add click functionality to CompletedStoryList item (#1706)
99ae9bb 
* Added topicId

* topic-id-in-completed-story

* Nit lint fix

* Added test cases

Co-authored-by: Rajat Talesra <talesra@google.com>
@rt4914
Fix #1681: Updated schema of state in json files. (#1682)
d8f1de5 
* Updated schema

* Nit fixes

* ktlint issue fix

* Changes justed by Ben

* Nit changes

* Updated implementation

* Removed unused protos

Co-authored-by: Rajat Talesra <talesra@google.com>
@prayutsu prayutsu merged commit 4195b6a into prayutsu:develop Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prayutsu @rt4914