Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit/action@v3.0.0 Depends on actions/cache@v3 which is using Node 16 which is now deprecated #189

Closed
bakerkj opened this issue Feb 5, 2024 · 4 comments

Comments

@bakerkj
Copy link

bakerkj commented Feb 5, 2024

This is the error message:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

actions/cache@v4 has been released for Node 20 please see https://github.com/actions/cache/releases/tag/v4.0.0
along with the specific PR actions/cache#1284.

Thanks!

@asottile
Copy link
Member

asottile commented Feb 5, 2024

fwiw this is just a warning not an error. github will transparently use the new node version without issue

@bakerkj
Copy link
Author

bakerkj commented Feb 6, 2024

@asottile yes thanks.

It does still produce a warning which does cause noise in our builds. It would be nice to fix the dependency either way.

Thanks!

@asottile
Copy link
Member

asottile commented Feb 6, 2024

feel free to send a patch

SukiCZ added a commit to SukiCZ/action that referenced this issue Feb 6, 2024
SukiCZ added a commit to SukiCZ/action that referenced this issue Feb 6, 2024
asottile added a commit that referenced this issue Feb 7, 2024
@khaeru khaeru mentioned this issue Feb 9, 2024
3 tasks
@bakerkj
Copy link
Author

bakerkj commented Feb 9, 2024

Thanks for the fix!

copybara-service bot pushed a commit to GoogleCloudPlatform/gcpdiag that referenced this issue Mar 14, 2024
pre-commit/action#189
https://github.com/pre-commit/action/releases/tag/v3.0.1

Bug: 328630225
Change-Id: Ib51d6249e99deb67e558b833e1b422a99aa2666b
GitOrigin-RevId: 71c7289
Unagi-zoso added a commit to Unagi-zoso/kupica that referenced this issue Apr 25, 2024
현재 버전3 에서 `test
Node.js 16 actions are deprecated` 이라는 경고가 여전히 떠서 최신 버전으로 업 시켰다.

ref)
[참고 자료](pre-commit/action#189)
anuraj-kool added a commit to anuraj-kool/anuraj-kool.github.io that referenced this issue Oct 2, 2024
as suggested by perplexity - https://www.perplexity.ai/search/the-following-actions-use-a-de-JdMTUMSSTXGvNFlATpWIew

To address the deprecated Node.js version warning for GitHub Actions, you should update the following actions to their latest versions that support Node.js 20:

1. Update actions/setup-node from v3 to v4:
Replace `actions/setup-node@v3` with `actions/setup-node@v4`[1].

2. Update actions/cache from v3 to v4:
Replace `actions/cache@v3` with `actions/cache@v4`[1][5].

These updates will resolve the deprecation warnings and ensure your GitHub Actions workflows use Node.js 20. Here's an example of how your updated workflow steps might look:

```yaml
steps:
  - uses: actions/checkout@v4
  - uses: actions/setup-node@v4
    with:
      node-version: '20'
  - uses: actions/cache@v4
    with:
      path: ~/.npm
      key: ${{ runner.OS }}-node-${{ hashFiles('**/package-lock.json') }}
```

By updating to these newer versions, you'll be using actions that are compatible with Node.js 20 and avoid the deprecation warnings[3][4].

## Additional Considerations

- **Dependabot**: To automate keeping your GitHub Actions up to date, consider using Dependabot. It can automatically create pull requests to update your action versions[3].

- **Other Actions**: If you're using other actions in your workflow, check if they also have newer versions available that support Node.js 20.

- **Testing**: After updating the action versions, thoroughly test your workflows to ensure they still function as expected.

By making these updates, you'll resolve the deprecation warnings and ensure your GitHub Actions workflows are using the latest supported Node.js version.

Citations:
[1] pre-commit/action#189
[2] https://community.sonarsource.com/t/github-action-versions-in-example-github-actions-workflow-outdated/114132
[3] https://discourse.julialang.org/t/github-actions-deprecated/111630
[4] https://stackoverflow.com/questions/77897660/github-actions-node-js-16-actions-are-deprecated-warning
[5] https://github.com/actions/cache?tab=readme-ov-file
[6] https://community.nethserver.org/t/module-build-fails-node-js-16-actions-are-deprecated/22778
[7] https://docs.docker.com/build/cache/backends/gha/
[8] https://docs.docker.com/build/ci/github-actions/cache/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants