-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tiltfile #494
Add Tiltfile #494
Conversation
so there is an odd precedent set in #413 that treats all starlark as "bazel" -- I don't think that's quite correct but then this should get resolved somehow so this PR isn't inconsistent we can't remove bazel from that extension so maybe the best is to just add it? |
@asottile rebased the PR and also now explicitly setting |
Looking at the @asottile anything else to do here as part of this PR? thanks! |
I'm hesitant to add |
ok. stripped the PR down to only add Tiltfile support. Starlark can be added in the future via further PRs if desired to existing and new files/extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Tiltfile
+ Starlarksupport. Tiltfiles are written in Starlark, which is a language intended for use as a configuration language. It was originally designed for the Bazel build system. Starlark is a dialect of Python.background: Lots of Python targeting pre-commit hooks (like ruff) can also be applied to Starlark files. This PR enables to apply those hooks via specifyingtypes_or: [starlark]
ortypes_or: [tiltfile]
ortypes_or: [bazel]
depending on what is needed. Not every Python pre-commit hook applies to every Starlark file, as there are different variants with some language features enabled or disabled.refs: