Set default event flags appropriate for event type #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @robertknight, I know it's been a while, but I was hoping to check in on the status of this -- we just got bitten by this again while debugging a test being migrated onto Enzyme. |
Set the `bubbles`, `cancelable` and `composed` flags to match the default value of these flags for a given event type. - Add a metadata map in `src/event-data.ts` which is adapted from `dom-testing-library` and describes the default init args and constructors for different events. Note that the event constructor is not currently used. That will happen separately. - Use this metadata in `MountRenderer` to set the default arguments passed to the `Event` constructor's second argument, unless overridden Fixes #129
robertknight
force-pushed
the
set-event-flags
branch
from
04203ae
to
0a1c6ab
Compare
Rename the event data module to match the current version of the module in dom-testing-library, from which it was taken. A few additional events have been added. There are still some additional media events in the DTL version which have not been added here yet.
|
Hi @mq2thez - I've had another look over this and checked that it doesn't cause unexpected issues in the test suites for the main codebases I work on. Can you confirm that it works as expected in your test suites? If so I'm happy to ship this. |
|
@robertknight Happy to report that after installing this branch, our full Jest suite still passes, and some individual tests I wrote to confirm the propagation happened pass as expected. Looks good to go! Thank you so much! |
|
This has been published as v3.3.0. |
|
Awesome, thanks a ton! This will definitely be a time saver =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the
bubbles,cancelableandcomposedflags to match thedefault value of these flags for a given event type.
Add a metadata map in
src/event-data.tswhich is adapted fromdom-testing-libraryand describes the default init args andconstructors for different events.
Note that the event constructor is not currently used. That will
happen separately.
Use this metadata in
MountRendererto set the default argumentspassed to the
Eventconstructor's second argument, unlessoverridden
Fixes #129
TODO:
event-data.tsdata