Upgrade workflow actions #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -62,5 +62,8 @@ | |||
| ], | |||
| "reporter": "html", | |||
| "all": true | |||
| }, | |||
| "volta": { | |||
| "node": "16.18.0" | |||
There was a problem hiding this comment.
Previously we weren't pinning the Node version. Since this package isn't (or shouldn't be) likely to break with Node updates, I would be inclined to run tests against the current Node LTS release.
There was a problem hiding this comment.
Oh! I thought v16 was the LTS, whoops! My motivation for adding this is that I am working in multiple repos that require various versions of Node, some of which I can't control how they specify which Node version to use. So my goal for adding this was to make sure I'm using the latest and greatest when developing in this repo (I meant to put this at the LTS).
If you'd prefer not to pin this repo for users of volta or for the workflow, I'm happy to remove.
andrewiggins
force-pushed
the
workflow-update
branch
from
4ad69c5
to
6176825
Compare
robertknight
approved these changes
Oct 31, 2022
andrewiggins
force-pushed
the
workflow-update
branch
from
6176825
to
468e7f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update workflow actions to their latest version and take advantage of new features