Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add husky and lint-staged flow for formatting #212

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Add husky and lint-staged flow for formatting #212

merged 2 commits into from
Oct 31, 2022

Conversation

andrewiggins
Copy link
Member

I keep hitting errors on the "checkformatting" step of workflows so I'm proposing we add husky + lint-staged to make formatting issues a thing of the past :)

robertknight
robertknight approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this seems useful. I'm willing to give it a try, though I try to be mindful of the number of development dependencies a project has.

@andrewiggins andrewiggins merged commit 2289217 into master Oct 31, 2022
@andrewiggins andrewiggins deleted the husky-lint-staged branch October 31, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertknight robertknight robertknight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewiggins @robertknight