-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/docs #1658
Chore/docs #1658
Conversation
🦋 Changeset detectedLatest commit: 92a2896 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -42,7 +42,7 @@ const options = [ | |||
}, | |||
{ | |||
name: '--template', | |||
description: 'Path to custom HTML template', | |||
description: 'Path to custom HTML template (default "src/template.html")', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't set this as an actual default value in sade
, only in the description, to keep this detection intact:
preact-cli/packages/cli/lib/lib/webpack/render-html-plugin.js
Lines 21 to 33 in 84dba1a
const inProjectTemplatePath = resolve(src, 'template.html'); | |
let template = defaultTemplate; | |
if (existsSync(inProjectTemplatePath)) { | |
template = inProjectTemplatePath; | |
} | |
if (config.template) { | |
const templatePathFromArg = resolve(cwd, config.template); | |
if (existsSync(templatePathFromArg)) template = templatePathFromArg; | |
else { | |
warn(`Template not found at ${templatePathFromArg}`); | |
} | |
} |
Just minor revisions to docs, in ReadMe and CLI