feat: support CRA-style proxy config #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aa8a292 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
commented
Mar 15, 2022
|
|
||
| return { | ||
| target, | ||
| logLevel: 'warn', |
There was a problem hiding this comment.
This will result in proxy issues appearing in the user's terminal like the following:
I tend to think that's handy, but we certainly could disable it and leave those errors to the browser console too.
ForsakenHarmony
approved these changes
Mar 29, 2022
rschristian
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes
Summary
Closes #1672
Some users copy/paste from CRA thinking their config will work out of the box. While that won't work everywhere, we can support simple cases like this pretty easily.
This implementation is pretty close to CRA's, though with a couple changes around the public folder and error handling.
I'm leaning towards not documenting this though, would rather people use their
preact.config.jsto better control this themselves. I think the defaults I've set are probably fine, but still not a "one size fits all" situation.Does this PR introduce a breaking change?
Technically, it could be problematic if a user has a (previously) extraneous key sitting around in their
package.json. Don't know if that counts and might be a bit of a reach.