fix: push-manifest.json
CSS asset type
#1736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
No
Summary
Bug introduced by typo in #1680
I believe this is more of a theoretical bug than a real issue at this time. Our test suite ensures everything is working as intended in the basic situations at least:
preact-cli/packages/cli/tests/images/build.js
Lines 219 to 237 in 6aba5d8
In order to handle async chunks generated by Webpack, we loop through the chunks and assign types accordingly. We don't skip the main route chunks while doing so despite them already being set (
which maybe we should correct but not really important either waydid it), so this corrected for the wrong type being set:preact-cli/packages/cli/lib/lib/webpack/create-load-manifest.js
Lines 52 to 56 in 6aba5d8
Does this PR introduce a breaking change?
No