-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed boolean check for running dev server in https #176
Conversation
src/commands/watch.js
Outdated
@@ -19,8 +19,7 @@ export default asyncCommand({ | |||
}, | |||
host: { | |||
description: 'Hostname to start a server on', | |||
default: '0.0.0.0', | |||
alias: 'h' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing the alias for the host
command since this is colliding with yargs
package's --help, -h
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this is supposed to be a separate PR, but since already a PR is in queue, it just appended !!
Sorry for the mess 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this to a seperate PR as your PR could be squashed to create a clean git history.
This reverts commit a4f71a1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍 Additional benefit - we'll be using same cert for preact serve
and preact watch
Removed boolean check for running dev server in https from here
Now you can run dev server in
HTTPS
Fix for bug #175