feat: Support proxied loaders w/ getLoadersByName() is user config
#1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bceb6e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
commented
Dec 22, 2022
| ); | ||
| .filter(({ loader }) => { | ||
| if (typeof loader === 'string') return loader.includes(name); | ||
| return typeof loader.loader === 'string' && |
There was a problem hiding this comment.
Not 100% that we need this type check here, but Webpack's types are quite loose and I don't want to break anyone's setup by changing behavior.
rschristian
changed the title
getLoadersByName() is user config
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature / bugfix
Did you add tests for your changes?
No
Summary
Closes #929
If the loader is being proxied (like say
sass-loader), we need to look a bit deeper then we normally would to get the "correct" loader.The interface here is a bit messy though, might be a bit confusing to users why there's this proxy loader:
[ { "rule": { "enforce": "pre", "test": "\.s[ac]ss$", "use": [ { "loader": "/home/ryun/Projects/foobar/node_modules/preact-cli/src/lib/webpack/proxy-loader.js", "options": { "cwd": "/home/ryun/Projects/foobar", "loader": "sass-loader", "options": { "sourceMap": true, "sassOptions": { "includePaths": [ "/home/ryun/Projects/foobar/node_modules", "/home/ryun/Projects/foobar/node_modules/preact-cli/node_modules" ] } } } } ] }, "ruleIndex": 2, "loader": { "loader": "/home/ryun/Projects/foobar/node_modules/preact-cli/src/lib/webpack/proxy-loader.js", "options": { "cwd": "/home/ryun/Projects/foobar", "loader": "sass-loader", "options": { "sourceMap": true, "sassOptions": { "includePaths": [ "/home/ryun/Projects/foobar/node_modules", "/home/ryun/Projects/foobar/node_modules/preact-cli/node_modules" ] } } } }, "loaderIndex": 0 } ]Does this PR introduce a breaking change?
No