Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async loader missing undefined check #1763

Merged
merged 3 commits into from
Dec 23, 2022

Conversation

rschristian
Copy link
Member

What kind of change does this PR introduce?

Bug fix

Did you add tests for your changes?

No

Summary

Closes #1424, #1721

Does this PR introduce a breaking change?

No

rschristian and others added 2 commits December 23, 2022 04:47
Co-authored-by: psabharwal123 <puneet.sabharwal@hotmail.com>
Co-authored-by: Sparrowhawk <sparrowhawk-ea@hotmail.com>
@rschristian rschristian requested a review from a team as a code owner December 23, 2022 10:49
@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2022

🦋 Changeset detected

Latest commit: f300aad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/async-loader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rschristian rschristian linked an issue Dec 23, 2022 that may be closed by this pull request
1 task
@rschristian rschristian changed the title fix: async loader missing null check fix: async loader missing undefined check Dec 23, 2022
@rschristian rschristian merged commit 3c371f7 into master Dec 23, 2022
@rschristian rschristian deleted the fix/async-loader-missing-null-check branch December 23, 2022 23:13
@preact-bot preact-bot mentioned this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant