fix: Ensure devServer info message uses actual devServer config #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e8d4182 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
commented
Jan 7, 2023
| @@ -8,7 +8,6 @@ exports.build = async function buildCommand(src, argv) { | |||
| argv.src = src || argv.src; | |||
| // add `default:true`s, `--no-*` disables | |||
| argv.prerender = toBool(argv.prerender); | |||
| argv.production = toBool(argv.production); | |||
There was a problem hiding this comment.
production is not a valid CLI flag, so it's been moved into run-webpack.js with the other derived env values.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
Did you add tests for your changes?
No
Summary
Essentially, we are normalizing CLI options way too late, causing inconsistencies.
As the output message didn't consume
webpack.devServer's config, there were some situations in which the two wouldn't match up: an example of this beingHTTPS=true yarn preact watch. We consumedprocess.env.HTTPSin the informational text, but not for the actual dev server config. The user would see an error if they tried to open the URL we provided in their browser.Does this PR introduce a breaking change?
Other information
Please paste the results of
preact infohere.