Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to stage-1 #184

Merged
merged 3 commits into from
Jul 4, 2017
Merged

Update to stage-1 #184

merged 3 commits into from
Jul 4, 2017

Conversation

SaraVieira
Copy link
Contributor

Since stage 0 is very unpredictable and quickly changes I think it would be better to update this to stage-1.

All we need is already in stage-1 and it's more predictable

What do you guys think ?

Copy link
Member

@prateekbh prateekbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y is yarn.lock needed?

@reznord
Copy link
Member

reznord commented Jul 4, 2017

@SaraVieira Yarn support for preact-cli is still WIP. You can check the status for that in here.

As far as this yarn.lock is concerned, please don't commit the file, some might use npm and some might use yarn.

@prateekbh
Copy link
Member

Will adding it to gitignore not help?

@reznord
Copy link
Member

reznord commented Jul 4, 2017

That should do !!

Copy link
Member

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove yarn.lock please. Intentionally not adding it to the repo, last I heard.

package.json Outdated
@@ -84,6 +84,7 @@
"babel-cli": "^6.24.0",
"babel-eslint": "^7.2.1",
"babel-plugin-transform-runtime": "^6.23.0",
"babel-preset-stage-1": "^6.24.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to dependency like stage 0? We need it there, not devDep

@SaraVieira
Copy link
Contributor Author

@lukeed yarn.lock removed and added to the gitignore
@thangngoc89 Also changed

Copy link
Collaborator

@thangngoc89 thangngoc89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@developit
Copy link
Member

ooh, the stages changed since I last looked - definitely agreed we don't need Do expressions or the function bind syntax. good call @SaraVieira!

Copy link
Member

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

@lukeed
Copy link
Member

lukeed commented Jul 4, 2017

Anyone know why Node 8 is failing with cannot find module 'jest-cli'? I've restarted it once & looks like someone else just did too 😅

@thangngoc89
Copy link
Collaborator

@lukeed I just restarted it. It failed. When we have a test problem, we shall ping @rkostrzewski

@SaraVieira
Copy link
Contributor Author

Thanks @developit!

I was gonna ask someone to restart it but apparently it didn't fix it 😐

@SaraVieira
Copy link
Contributor Author

It did pass now 😄

Is this okay to merge guys ?

@rkostrzewski
Copy link
Collaborator

Removed cache for build. Commiting yarn.lock seems to have changed node_modules structure and cached entities had incorrect structure. Weird.

@rkostrzewski rkostrzewski merged commit ba26fc7 into preactjs:master Jul 4, 2017
@SaraVieira SaraVieira deleted the stage-0 branch July 4, 2017 19:10
@rkostrzewski rkostrzewski added this to the 1.4.0 milestone Jul 5, 2017
@hzoo
Copy link

hzoo commented Jul 18, 2017

just as fyi, stage 3 is what is "predictable". Stage 0 is basically automatically ok if someone champions it at TC39, and stage 1 isn't that much different. It's best to opt-in to individual plugins/proposals rather than use stages before Stage 3 but currently we leave it there as an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants