-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to stage-1 #184
Update to stage-1 #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Y is yarn.lock needed?
@SaraVieira Yarn support for As far as this yarn.lock is concerned, please don't commit the file, some might use |
Will adding it to gitignore not help? |
That should do !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove yarn.lock
please. Intentionally not adding it to the repo, last I heard.
package.json
Outdated
@@ -84,6 +84,7 @@ | |||
"babel-cli": "^6.24.0", | |||
"babel-eslint": "^7.2.1", | |||
"babel-plugin-transform-runtime": "^6.23.0", | |||
"babel-preset-stage-1": "^6.24.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this to dependency like stage 0? We need it there, not devDep
@lukeed yarn.lock removed and added to the gitignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
ooh, the stages changed since I last looked - definitely agreed we don't need Do expressions or the function bind syntax. good call @SaraVieira! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🙌
Anyone know why Node 8 is failing with |
@lukeed I just restarted it. It failed. When we have a test problem, we shall ping @rkostrzewski |
Thanks @developit! I was gonna ask someone to restart it but apparently it didn't fix it 😐 |
It did pass now 😄 Is this okay to merge guys ? |
Removed cache for build. Commiting |
just as fyi, stage 3 is what is "predictable". Stage 0 is basically automatically ok if someone champions it at TC39, and stage 1 isn't that much different. It's best to opt-in to individual plugins/proposals rather than use stages before Stage 3 but currently we leave it there as an option. |
Since stage 0 is very unpredictable and quickly changes I think it would be better to update this to stage-1.
All we need is already in stage-1 and it's more predictable
What do you guys think ?