-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Friendly prerender message + remove UglifyJS from SSR build #195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is freaking awesome !!!
Best DX ever <3 <3
But we might want to consider add some info about prerender (why? cons?) and point user to that page. Because currently, there are no info about this on README
Heh, previously I've had |
Looks great @rkostrzewski ! 😻 Quick question though: Why was uglify removed on SSR? UglifyJS was mangling the maps, ergo making tracing impossible? |
@lukeed that's one of the reasons there other being that chief said so 😆, right @developit ? |
@rkostrzewski Lol 😂 Just went thru that Slack. Looks like Chief said that because of the source map issues! |
I notice this suggests people should check for window. I always just use this: https://www.npmjs.com/package/window-or-global It also makes SSR work for a bunch of features that need global, and it doesn't break even if you run things like eventListeners on global. |
# Conflicts: # src/lib/webpack/webpack-client-config.js
…t for catching top level calls
@thangngoc89 I've added |
@rkostrzewski LGTM |
This closes #178