Suggest a new port for development server if default port is in use. #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops !! committed My bad :( |
reznord
commented
Jul 5, 2017
src/lib/webpack/run-webpack.js
Outdated
| process.stdout.write(chalk.green('Compiled successfully!!\n\n')); | ||
| process.stdout.write('You can view the application in the browser.\n\n'); | ||
| process.stdout.write(chalk.green('\nCompiled successfully!!\n\n')); | ||
| if (parseInt(port, 10) !== parseInt(config.devServer.port, 10)) { |
There was a problem hiding this comment.
Showing this message only when it is not using default port. So, it will be easy for the users to understand what port it has been changed to !!
lukeed
requested changes
Jul 5, 2017
|
This fixes #179 |
lukeed
approved these changes
Jul 5, 2017
There was a problem hiding this comment.
I forgot I could push to PRs 😅
I added changes so that we only showed the "using different port" message if user actually defined a port. Since 8080 is a default (aka, not specified) I don't think we have to warn/alert users about the change.
Also, moved parseInt call to process.env.PORT only because it's the only item that is passed in as a string.
Looks good, thanks!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR opens dev server in a new port if the default port is already in use.
Here's how it looks:
