enabling create app in current directory #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekbh
commented
Jul 12, 2017
src/commands/create.js
Outdated
| type: 'confirm', | ||
| name: 'enableForce', | ||
| message: `You are using '--force'. Do you wish to continue?`, | ||
| default: true, |
There was a problem hiding this comment.
default should be false
There was a problem hiding this comment.
Okay, will change it once I reach home.
Sent from my OnePlus ONEPLUS A3003 using FastHub
prateekbh
commented
Jul 12, 2017
src/commands/create.js
Outdated
| if (exists && !argv.force) { | ||
| throw Error('Directory already exists.'); | ||
| throw Error('Cannot intialize in the current directory, please specify a different destination.'); |
There was a problem hiding this comment.
can we write messages using chalk?
There was a problem hiding this comment.
Oh sure, not a problem at all. Red color?
Sent from my OnePlus ONEPLUS A3003 using FastHub
developit
reviewed
Jul 12, 2017
src/commands/create.js
Outdated
| throw Error('Directory already exists.'); | ||
| if (exists && argv.force) { | ||
| const question = { | ||
| type: 'confirm', |
rkostrzewski
requested changes
Jul 12, 2017
src/commands/create.js
Outdated
| if (forceInit.enableForce) { | ||
| process.stdout.write('Initializing project in the current directory...\n'); | ||
| } else { | ||
| process.stdout.write(`${chalk.red('Error:')} Cannot initialize in the current directory`); |
There was a problem hiding this comment.
Should be process.stderr.write. BTW why not color whole message to red?
src/commands/create.js
Outdated
| } | ||
|
|
||
| if (exists && !argv.force) { | ||
| process.stdout.write(`${chalk.red('Error:')} Cannot initialize in the current directory, please specify a different destination`); |
There was a problem hiding this comment.
Should be process.stderr.write
src/commands/create.js
Outdated
| default: false, | ||
| }; | ||
|
|
||
| let forceInit = await inquirer.prompt(question); |
There was a problem hiding this comment.
Hint: let { enableForce } = , also enableForce:
rkostrzewski
approved these changes
Jul 12, 2017
|
Let the tests run !! :P Merging this one 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110
by specifying --force this will allow you to create project in current directory.
@developit just curious, the discussion emphasize upon the usage of
--force?What if we do it without this? Whats the harm with that?