feature: yarn install (through a flag) #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing #31 in favour of this |
|
Here is the latest log from the failed tests - https://gist.github.com/reznord/f69ddcf6f0caad99bb9d83ce61381ca8 Progress: Tests are not failing that worse 😛 |
developit
reviewed
Jul 16, 2017
| '--prefix', process.cwd(), | ||
| ...deps | ||
| ].filter(Boolean)).then( () => { | ||
| return install(false, process.cwd(), deps, save).then( () => { |
There was a problem hiding this comment.
Would it make sense to allow yarn here if it's installed? We could check for a yarn.lock as an indication of whether the current repo is set up with yarn.
developit
approved these changes
Jul 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for yarn in the application. 🎉
User can install & use yarn by adding a flag
--yarnwhen he initializes a project usingpreact create my_app --yarn.Added
install-dependencies.jssince I want to keepcreate.jsclean and simple.For now cancelling the tests since they will fail for sure 😛
Tests are the only thing that are failing now, else we are good to go with
yarn😎@rkostrzewski @developit please help with the tests !!