No git #237
Merged
No git #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reznord
reviewed
Jul 17, 2017
| @@ -56,7 +56,7 @@ export default asyncCommand({ | |||
| git: { | |||
| description: 'Initialize version control using git', | |||
| type: 'boolean', | |||
| default: true | |||
| default: false | |||
There was a problem hiding this comment.
I'm not really sure if setting --git to false by default or not.
Leaving --git to true by default and not making an initial commit makes sense to me.
@developit any thoughts?
There was a problem hiding this comment.
I think we are trying to hard here. User know how to initilize a git repo. Just leave it to user.
|
ok, Option B: leave @thangngoc89 @reznord which one do you think guys? |
|
@prateekbh I'm good with both, anyways for Option B it is just a matter of one command away. So, I'm with @thangngoc89 here. |
reznord
approved these changes
Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216,
This will put --git in default state of
falseso that when user says --git he knows that there will some git activity, and we wont do aut commits without his knowledge