Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link :active/:hover color accessibility in the examples #241

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Fix link :active/:hover color accessibility in the examples #241

merged 1 commit into from
Jul 18, 2017

Conversation

developit
Copy link
Member

/cc @reznord

reznord
reznord approved these changes Jul 18, 2017
View reviewed changes
Copy link
Member

@reznord reznord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaay, we got those 3 points back 😎

@reznord reznord merged commit 123cc8e into master Jul 18, 2017
@developit developit deleted the link-color-a11y branch July 18, 2017 19:38
@bestwestern
Copy link

bestwestern commented Jul 26, 2017 •
edited
Loading

'preact create my-great-app' still doesn't have different color on the active route?
problem is

				<Link activeClassName="active" href="/">Home</Link>
				<Link activeClassName="active" href="/profile">Me</Link>
				<Link activeClassName="active" href="/profile/john">John</Link>

should be:

				<Link activeClassName={style.active} href="/">Home</Link>
				<Link activeClassName={style.active} href="/profile">Me</Link>
				<Link activeClassName={style.active} href="/profile/john">John</Link>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reznord reznord reznord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@developit @bestwestern @reznord