make interop conditional more clear #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reznord
approved these changes
Aug 18, 2017
| @@ -9,7 +9,7 @@ else if ('serviceWorker' in navigator && location.protocol === 'https:') { | |||
| } | |||
|
|
|||
|
|
|||
| const interopDefault = m => m && m.default || m; | |||
| const interopDefault = m => m && m.default ? m.default : m; | |||
|
|
|||
There was a problem hiding this comment.
This is easy to understand.
👍 LGTM!
There was a problem hiding this comment.
true, but easy to understand ;)
|
The way I see it is extractly the same. This is actually common in JS codebases. Try jQuery :D |
|
heh yeah they look the same to me, but I am also a masochist |
|
I'm a fan of the |
|
we are mutants |
|
or simulations 💻 |
|
Count me in !! ;) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.