Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive Prompts #359

Merged
merged 3 commits into from
Sep 6, 2017
Merged

Interactive Prompts #359

merged 3 commits into from
Sep 6, 2017

Conversation

lukeed
Copy link
Member

@lukeed lukeed commented Sep 5, 2017

During preact create, if user does not provide the required arguments (template and dest) we will run them thru the list of all fields (6 total). This ensures we have all the info we need & exposes the user to all available options that the may have missed.

This is what it looks like:

screen shot 2017-09-05 at 12 14 30 pm

Prompting all fields as a result of the Poll in #352


Closes #358, #352

@lukeed lukeed requested review from developit and reznord September 6, 2017 04:21
Copy link
Member

@reznord reznord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from this, every thing looks great :)

};

// Required data
!argv.template && ask('template', 'Remote template to clone (user/repo#tag)');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to show the default value here. Like what we did for preact init?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically its like having a fallback value for all the prompts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no default value -- it's required.

@lukeed
Copy link
Member Author

lukeed commented Sep 6, 2017

Oh, @reznord, here's another screenshot of the prompt before answering. It shows N because false is the default here.

screen shot 2017-09-05 at 10 59 22 pm

@reznord
Copy link
Member

reznord commented Sep 6, 2017

True! That is what we can do for the input fields too right?

@reznord
Copy link
Member

reznord commented Sep 6, 2017

@lukeed slack'in you (have a few suggestions for this)

@lukeed
Copy link
Member Author

lukeed commented Sep 6, 2017

True! That is what we can do for the input fields too right?

For dest and template, no. We don't want to set any default for those since those are the only two distinct, required fields that the user needs to declare.

For name, it's possible, but I don't see a point in doing it. Perhaps My App but even then, it's not that useful imo.

@reznord
Copy link
Member

reznord commented Sep 6, 2017

Makes sense! :)

@reznord reznord merged commit aeb4159 into master Sep 6, 2017
@lukeed lukeed deleted the prompts-fallback branch September 6, 2017 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants