-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive Prompts #359
Interactive Prompts #359
Conversation
- [poll] asks for ALL fields - Closes #352
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from this, every thing looks great :)
}; | ||
|
||
// Required data | ||
!argv.template && ask('template', 'Remote template to clone (user/repo#tag)'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to show the default value here. Like what we did for preact init
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically its like having a fallback value for all the prompts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no default value -- it's required.
Oh, @reznord, here's another screenshot of the prompt before answering. It shows |
True! That is what we can do for the input fields too right? |
@lukeed slack'in you (have a few suggestions for this) |
For For |
Makes sense! :) |
During
preact create
, if user does not provide the required arguments (template
anddest
) we will run them thru the list of all fields (6 total). This ensures we have all the info we need & exposes the user to all available options that the may have missed.This is what it looks like:
Prompting all fields as a result of the Poll in #352
Closes #358, #352