Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: preact list #384

Merged
merged 8 commits into from
Sep 26, 2017
Merged

feature: preact list #384

merged 8 commits into from
Sep 26, 2017

Conversation

reznord
Copy link
Member

@reznord reznord commented Sep 25, 2017

New command to the CLI: preact list

Now that we have moved to custom templates, it is better to add a CLI command which will list out the official repos.

Edit: It fetches the list of repos from the URL https://api.github.com/users/preactjs-templates/repos.

@reznord reznord requested review from developit and lukeed September 25, 2017 20:05
@reznord
Copy link
Member Author

reznord commented Sep 25, 2017

Added to README in #383 (commit ref: 0c6df1b)

lukeed
lukeed previously requested changes Sep 26, 2017
Copy link
Member

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use unfetch or isomorphic-unfetch instead of axios. No reason to require another dependency.

@reznord
Copy link
Member Author

reznord commented Sep 26, 2017

Please use unfetch or isomorphic-unfetch instead of axios

I didn't use unfetch since we are not running this in browser. We will be running it on node.

Re isomorphic-unfetch, I tried that but it gives a weird output instead of the body.

/cc @lukeed

Edit: I was being an idiot while working on this, my bad. 😅

@developit
Copy link
Member

heh - streams!

Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome

@reznord reznord dismissed lukeed’s stale review September 26, 2017 12:16

ayee, removed axios and used isomorphic-unfetch

@reznord reznord added this to the 2.0 milestone Sep 26, 2017
@lukeed lukeed merged commit 426f547 into master Sep 26, 2017
@lukeed lukeed deleted the preact-list branch September 26, 2017 17:13
developit added a commit that referenced this pull request Oct 11, 2017
* master: (166 commits)
  Use `publicPath` for SW & Manifest paths (#323)
  Purge `examples` dir (#393)
  Update Readme (#383)
  Add `preact list` command (#384)
  linters are dumb
  inject / replace strings in extracted contents
  adding flag to disable service worker
  Convert `css-loader` options to an Object (#349)
  remove `offline-plugin` (unused)
  remove `mkdirp` (unused)
  remove `less` dependencies
  fix linter
  move `htmlPlugin` to `render-html-plugin.js`
  install `css|postcss|style-loader` & regen `yarn.lock`
  remove `chunk.modules` deprecation notice
  rewrite server’s `webpack.config` without blocks
  rewrite client’s `webpack.config` without blocks
  install `webpack-merge`
  rewrite base `webpack.config` w/o blocks
  light refactor
  ...

# Conflicts:
#	src/lib/webpack/webpack-base-config.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants