Allow PostCSS to sourceMap in Dev mode
#407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reznord
reviewed
Oct 19, 2017
| @@ -142,7 +142,7 @@ export default function (env) { | |||
| { | |||
| loader: 'postcss-loader', | |||
| options: { | |||
| sourceMap: isProd, | |||
| sourceMap: true, | |||
There was a problem hiding this comment.
can't we leave this in the user land whether to use sourceMaps in production or not?
There was a problem hiding this comment.
I'm fine with both the options tho
There was a problem hiding this comment.
This isn't production. This just always allows PostCSS to accept source maps. Whether or not source maps are created is determined by the (css|sass|stylus|less)-loaders.
This can still be overridden in Userland, if wanted, but there'd be no point.
Development sourcemaps don't work with out this.
reznord
approved these changes
Oct 20, 2017
| @@ -142,7 +142,7 @@ export default function (env) { | |||
| { | |||
| loader: 'postcss-loader', | |||
| options: { | |||
| sourceMap: isProd, | |||
| sourceMap: true, | |||
There was a problem hiding this comment.
I'm fine with both the options tho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR (#404) enabled
sourceMaps for production builds only. Derp. This enables mapping during development.Closes #403 ... again