closes #474 - add index.html to default ignore list for SWPrecacheWeb… #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But this still allows it in |
|
I believe that offline ability is broken without I have a new project open, lemme confirm quickly. |
lukeed
requested changes
Apr 9, 2018
|
my bad, did not test offline mode. let me find out better solution. |
|
This works correctly as designed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #474 - add index.html to default ignore list for SWPrecacheWebpackPlugin
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes (appears to be working ok in my local tests)
Summary
as documented in #474 caching index.html causes issues with service worker caching.
Does this PR introduce a breaking change?
Other information