Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Incorrect dev server address in console #57

Merged
merged 5 commits into from
May 25, 2017
Merged

fix: Incorrect dev server address in console #57

merged 5 commits into from
May 25, 2017

Conversation

rkostrzewski
Copy link
Collaborator

Fixes #55

I should probably stop spamming with those PRs 😅

lukeed
lukeed requested changes May 24, 2017
View reviewed changes
Copy link
Member

@lukeed lukeed left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to PR this too 😄 Our fearless @developit prefers let tho -- mind quick fixing?

@rkostrzewski
Copy link
Collaborator Author

rkostrzewski commented May 24, 2017 •
edited
Loading

Why tho?

Bet it is 2x faster, or generated JS is smaller 😆

lukeed
lukeed approved these changes May 24, 2017
View reviewed changes
Copy link
Member

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is just his preference, we like to bug him about it 😜

But "easier to write" and "const for globals" are what's usually tossed around. Makes sense~

Thanks!

@developit
Copy link
Member

image

developit
developit approved these changes May 25, 2017
View reviewed changes
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A+ would let again

@developit developit merged commit c079ba6 into preactjs:master May 25, 2017
@lukeed
Copy link
Member

lukeed commented May 25, 2017

I didn't comment on the commit message because I wanted to give you the joy and surprise of discovering it lol. 11/10, well played sir

@rkostrzewski rkostrzewski deleted the fix/dev-server-notice branch June 23, 2017 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeed lukeed lukeed approved these changes

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkostrzewski @developit @lukeed