Fix #87 #92
Merged
Fix #87 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkostrzewski
previously approved these changes
Jun 5, 2017
developit
reviewed
Jun 5, 2017
src/lib/webpack-config.js
Outdated
| include: /babel-helper$/, | ||
| patterns: [{ | ||
| regex: /throw\s+(new\s+)?(Type|Reference)?Error\s*\(/g, | ||
| value: 'return;(' |
There was a problem hiding this comment.
as per slack, we should make sure to retain the offset here via space padding:
value: s => `return;${new Array(s.length-8).join(' ')}(`
|
Hmm... Updated with @developit's suggestion for source-mapping (via character length). |
jmadler
reviewed
Jun 7, 2017
developit
approved these changes
Jun 7, 2017
|
@jmadler 😆 I giggled. Glad to hear! @developit Your lead, good sir -- I'd feel strange merging own PR. |
|
@developit When can we expect fixes for firebase in preact-cli ?. Working on an existing app porting from react to preact ;) got stuck with firebase uglify issue :) |
|
@gokulkrishh today! |
|
@developit Cool. Thanks 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new
webpack-plugin-replacein order to move forward & close #87.I can add & update this plugin as needed 👍
As it is, I went through the reproduction steps & it has been fixed.