This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while debugging why
prop-types
didn't work inpreact-cli
(see: preactjs/preact-cli#627).Turns out the reason is that our global
DEV
variable was always set tofalse
whenpreact-compat
was bundled. The reason being that we checked ifprocess
is available:But bundlers typically don't shim the
process
object and instead replace all string occurrences ofprocess.env.NODE_ENV
withdevelopment
for example. After the bundler has done its magic the code would now look like this:Note that
process
is stillundefined
which is whyDEV
will always be false.