Fix Suspense nodes not recognized #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basics of a Suspense node appearing are validated, but not yet all details as devtools does not display final children yet.
🦋 Changeset is good to goLatest commit: 8f361f3 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the work in #260.
With these changes
Suspensenodes are now correctly detected and displayed. Note that Preact versions <10.4.5 used a rawComponentclass as a wrapper which is visible here. Newer Preact versions use aFragmentfor that which we'll filter out automatically.There was one oddity in regards to the children of a
Suspensevnode. They can't be cached as Preact modifies them outside the usual render cycle.