-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace renderToString
to renderToStringAsync
#10
Replace renderToString
to renderToStringAsync
#10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, one last tiny thing: the JSDoc & types need to be corrected now that options.maxDepth
has no effect
Line 4 in 1a25d79
maxDepth?: number; |
Line 15 in 1a25d79
* @param {number} [options.maxDepth = 10] The maximum number of nested asynchronous operations to wait for before flushing |
Otherwise, looks good to me. Thank you so much for fixing this!
@rschristian |
Cheers, I'll probably wait a couple days before making a new release, just to see if anything else can get released at the same time. |
When will this be released? |
Just did, thanks for the reminder! |
ref preactjs/wmr#965 (comment)
What is I did
preact-render-to-string
v6.4.0renderToString
torenderToStringAsync