Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace renderToString to renderToStringAsync #10

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

takurinton
Copy link
Contributor

ref preactjs/wmr#965 (comment)

What is I did

  • Update preact-render-to-string v6.4.0
    • Because renderToStringAsync was exported from this version
  • Replace renderToString to renderToStringAsync

src/prerender.js Outdated Show resolved Hide resolved
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one last tiny thing: the JSDoc & types need to be corrected now that options.maxDepth has no effect

maxDepth?: number;

* @param {number} [options.maxDepth = 10] The maximum number of nested asynchronous operations to wait for before flushing

Otherwise, looks good to me. Thank you so much for fixing this!

@takurinton
Copy link
Contributor Author

@rschristian
Thank you!! fixed!! 🙇

@rschristian rschristian merged commit 9dc0bff into preactjs:main Mar 19, 2024
@rschristian
Copy link
Member

Cheers, I'll probably wait a couple days before making a new release, just to see if anything else can get released at the same time.

@takurinton takurinton deleted the fix-render-to-string-async branch March 19, 2024 01:49
@takurinton
Copy link
Contributor Author

@rschristian

When will this be released?

@rschristian
Copy link
Member

Just did, thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants