Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null check for link before usage #47

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Add null check for link before usage #47

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bfd652
Add null check for link before usage
tomjw64 Oct 20, 2024
0a564e1
Respect author formatting
tomjw64 Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,13 @@ const UPDATE = (state, url) => {
return state;
}

const link = url.target.closest('a[href]'),
href = link.getAttribute('href');
rschristian marked this conversation as resolved.
Show resolved Hide resolved
const link = url.target.closest('a[href]');
if (!link) {
return state;
}

const href = link.getAttribute('href');
if (
!link ||
link.origin != location.origin ||
/^#/.test(href) ||
!/^(_?self)?$/i.test(link.target) ||
Expand Down