-
-
Notifications
You must be signed in to change notification settings - Fork 92
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix instance where renderToStringAsync returns a promise of a promise (…
…#378) * Fix issue where rendered is a promise I want to test this in my project to see if this change fixes it. All being well, I'll then add a test here and submit it for review * Different syntax, but more success I'm unclear why the previous didn't seem to work for me * Attempt to write a test for the case based on my app So far no luck actually reproducing the issue. I will take a different tact and remove code from my app until the issue goes away, to figure out what causes the behaviour. * Add test that tests behaviour * Further simplify test case * Further simplify test case * Create the test I want * Revert unrelated change * Add changeset * Add missing imports * Reproduce without useClient But I still need the provider * Avoid using urql * Better description * Update test/compat/async.test.jsx --------- Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
- Loading branch information
1 parent
ae6450b
commit 054dae0
Showing
3 changed files
with
73 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'preact-render-to-string': patch | ||
--- | ||
|
||
Fix issue where preactRenderToString returns a promise of a promise |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters