Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve perf with array pre-allocate #403

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

JoviDeCroock
Copy link
Member

Text:
baseline x 434.471 ops/sec ±2.09 (89 runs sampled)
current x 455.816 ops/sec ±1.35 (88 runs sampled)

Fastest is current

SearchResults:
baseline x 2,124.763 ops/sec ±3.50 (92 runs sampled)
current x 2,174.318 ops/sec ±4.29 (88 runs sampled)

Fastest is current

ColorPicker:
baseline x 12,934.781 ops/sec ±1.34 (95 runs sampled)
current x 13,121.543 ops/sec ±0.87 (97 runs sampled)

Fastest is current

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 7fcc557

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-render-to-string Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, where else do we use arrays? Month of free perf boosts!

Might look at copying over some of the benching setup from the core repo, having to bump the baseline-rts pkg ain't ideal

@JoviDeCroock JoviDeCroock merged commit ed720ef into main Dec 12, 2024
1 check passed
@JoviDeCroock JoviDeCroock deleted the preallocate-arrays branch December 12, 2024 08:24
@github-actions github-actions bot mentioned this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants