Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cascading import #1009

Merged
merged 1 commit into from
Aug 27, 2023
Merged

support cascading import #1009

merged 1 commit into from
Aug 27, 2023

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Aug 27, 2023

fixes #1008

It looks like esm.sh now has a new import when the file from https://esm.sh/preact@10.17.1 is initially loaded 😅 this amounted to us throwing an invalid URL for the block that is shielded with try catch in doing so it works correctly.

Example output of id, importer

/stable/preact@10.17.1/es2022/preact.mjs preact
/stable/preact@10.17.1/es2022/preact.mjs preact/hooks
/stable/preact@10.17.1/es2022/hooks.js preact/hooks
/stable/preact@10.17.1/es2022/preact.mjs stable/preact@10.17.1/es2022/hooks.js

all of these start with a slash but aren't valid URLs when combined.

Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh nice catch.

@developit developit merged commit 7da2d20 into master Aug 27, 2023
5 checks passed
@developit developit deleted the cascading-import branch August 27, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full Preact Tutorial Bug
2 participants