optimize by not accessing the dom

preactjs · Jun 25, 2024 · 4c114f9 · 4c114f9
1 parent e69f7e4
commit 4c114f9
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/diff/children.js b/src/diff/children.js
@@ -117,7 +117,7 @@ export function diffChildren(
 			oldVNode._children === childVNode._children
 		) {
 			// @ts-expect-error olDom should be present on a DOM node
-			if (oldDom && oldDom.nodeType === 1 && !parentDom.contains(oldDom)) {
+			if (oldDom && typeof childVNode.type == 'string' && !oldDom.isConnected) {
 				oldDom = getDomSibling(oldVNode);
 			}
 			oldDom = insert(childVNode, oldDom, parentDom);