Merge pull request #3680 from preactjs/fix-jsx-element

undo jsx-element removal
preactjs · Aug 19, 2022 · 5362360 · 5362360
2 parents b7072ad + 0fd11bc
commit 5362360
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 16 deletions.
diff --git a/src/index.d.ts b/src/index.d.ts
@@ -87,7 +87,7 @@ export type ComponentProps<
 	: never;
 
 export interface FunctionComponent<P = {}> {
-	(props: RenderableProps<P>, context?: any): ComponentChild;
+	(props: RenderableProps<P>, context?: any): VNode<any>;
 	displayName?: string;
 	defaultProps?: Partial<P>;
 }

diff --git a/src/jsx.d.ts b/src/jsx.d.ts
@@ -36,6 +36,7 @@ export namespace JSXInternal {
 					: never;
 		  }[keyof IntrinsicElements]
 		| ComponentType<P>;
+	export interface Element extends VNode<any> {}
 	export type ElementClass = Component<any, any> | FunctionComponent<any>;
 
 	export interface ElementAttributesProperty {

diff --git a/test/ts/preact.tsx b/test/ts/preact.tsx
@@ -102,21 +102,22 @@ const UseOfComponentWithChildren = () => {
 	);
 };
 
-const DummyChildren: FunctionalComponent = ({ children }) => {
-	return children;
-};
-
-function ReturnChildren(props: { children: preact.ComponentChildren }) {
-	return props.children;
-}
-
-function TestUndefinedChildren() {
-	return (
-		<ReturnChildren>
-			<ReturnChildren>Hello</ReturnChildren>
-		</ReturnChildren>
-	);
-}
+// TODO: make this work
+// const DummyChildren: FunctionalComponent = ({ children }) => {
+// 	return children;
+// };
+
+// function ReturnChildren(props: { children: preact.ComponentChildren }) {
+// 	return props.children;
+// }
+
+// function TestUndefinedChildren() {
+// 	return (
+// 		<ReturnChildren>
+// 			<ReturnChildren>Hello</ReturnChildren>
+// 		</ReturnChildren>
+// 	);
+// }
 
 // using ref and or jsx
 class ComponentUsingRef extends Component<any, any> {