Skip to content

Commit

Permalink
Merge pull request #4511 from preactjs/ci/artifact-versions
Browse files Browse the repository at this point in the history
ci: Bump upload/download-artifact action versions
  • Loading branch information
rschristian authored Sep 27, 2024
2 parents d898b43 + 461a6ec commit 5f8a884
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 17 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ jobs:
timeout-minutes: 5
steps:
- name: Download locally built preact package
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: npm-package
- run: mv preact.tgz preact-local.tgz
- name: Upload locally built preact package
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: bench-environment
path: preact-local.tgz
Expand All @@ -43,7 +43,7 @@ jobs:
required: false
- run: mv preact.tgz preact-main.tgz
- name: Upload base preact package
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: bench-environment
path: preact-main.tgz
Expand Down Expand Up @@ -106,4 +106,4 @@ jobs:
needs: prepare
with:
benchmark: filter-list/filter-list
timeout: 10
timeout: 10
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
npm pack --ignore-scripts
mv preact-*.tgz preact.tgz
- name: Upload npm package
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.artifact_name || 'npm-package' }}
path: preact.tgz
path: preact.tgz
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
needs: build
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: npm-package
- name: Create draft release
Expand All @@ -26,4 +26,4 @@ jobs:
with:
script: |
const script = require('./scripts/release/upload-gh-asset.js')
return script({ require, github, context, glob, release: ${{ steps.create-release.outputs.result }} })
return script({ require, github, context, glob, release: ${{ steps.create-release.outputs.result }} })
8 changes: 4 additions & 4 deletions .github/workflows/run-bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
${{ runner.os }}-pnpm-store-
# Install benchmark dependencies
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: bench-environment
- name: Move tarballs from env to correct location
Expand Down Expand Up @@ -109,13 +109,13 @@ jobs:
NAME=$(echo "${{ inputs.benchmark }}" | sed -r 's/[\/]+/_/g')
echo "artifact_name=logs_$NAME" >> $GITHUB_OUTPUT
- name: Upload results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: results
path: benchmarks/out/results/${{ inputs.benchmark }}.json
- name: Upload logs
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ steps.log-artifact-name.outputs.artifact_name }}
path: benchmarks/out/${{ inputs.benchmark }}_logs.tgz
if-no-files-found: ignore
if-no-files-found: ignore
10 changes: 5 additions & 5 deletions .github/workflows/single-bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ jobs:
timeout-minutes: 5
steps:
- name: Download locally built preact package
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: npm-package
- run: mv preact.tgz preact-local.tgz
- name: Upload locally built preact package
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: bench-environment
path: preact-local.tgz
Expand All @@ -73,12 +73,12 @@ jobs:
echo "===================="
ls -al
- name: Download base package
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: base-npm-package
- run: mv preact.tgz preact-main.tgz
- name: Upload base preact package
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: bench-environment
path: preact-main.tgz
Expand All @@ -90,4 +90,4 @@ jobs:
with:
benchmark: ${{ inputs.benchmark }}
trace: ${{ inputs.trace }}
# timeout: ${{ inputs.timeout }}
# timeout: ${{ inputs.timeout }}

0 comments on commit 5f8a884

Please sign in to comment.