fix: remove role attribute when it's null or undefined (#4137)

* add failing test * fix `role` not being removed * add PR number in test case
preactjs · Sep 20, 2023 · 64be3cb · 64be3cb
1 parent 7dc66bc
commit 64be3cb
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/diff/props.js b/src/diff/props.js
@@ -123,6 +123,7 @@ export function setProperty(dom, name, value, oldValue, isSvg) {
 			name !== 'download' &&
 			name !== 'rowSpan' &&
 			name !== 'colSpan' &&
+			name !== 'role' &&
 			name in dom
 		) {
 			try {

diff --git a/test/browser/render.test.js b/test/browser/render.test.js
@@ -1281,4 +1281,21 @@ describe('render()', () => {
 		render(<div tabindex={null} />, scratch);
 		expect(scratch.firstChild.tabIndex).to.equal(defaultValue);
 	});
+
+	// #4137
+	it('should unset role if null || undefined', () => {
+		render(
+			<section>
+				<div role="status">role="status"</div>
+				<div role={undefined}>role="undefined"</div>
+				<div role={null}>role="null"</div>
+			</section>,
+			scratch
+		);
+
+		const divs = scratch.querySelectorAll('div');
+		expect(divs[0].hasAttribute('role')).to.equal(true);
+		expect(divs[1].hasAttribute('role')).to.equal(false);
+		expect(divs[2].hasAttribute('role')).to.equal(false);
+	});
 });