-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class attribute not cleared when re-using elements from cache pool #97
Comments
Hi @steelbrain - there is a gitter room, gitter.im/developit/preact I suspect this may be related to the manual Element insertion via appendChild - this ends up getting recollected by preact's recycled, but it does not have any props associated because it was not created by preact. I can look into supporting that though, otherwise preact really shouldn't be recollecting an Element it didn't create. |
Please note that the examples demonstrated don't use |
Fix released in 4.4. |
Beautiful, thanks again! 👍 |
@developit - gitter.im/developit/preact doesn't seem to exist. is there a replacement? |
nevermind, found it the new chat is at preact.slack.com you must sign up from https://preact-slack.now.sh instead |
Add full support for custom element event names
I am hitting a very weird and difficult to reproduce bug. It would be nice to have a Slack, Gitter or IRC channel for preact where I can collaborate with the community to repro it.
The bug I'm hitting is with
Message
Component of linter-ui-default.It should, according to the code produce messages like this, and it does
but after a few dozen
render
triggers, it becomes thisNothing on our component side changes, I believe the bug to be on preact's side
Update
After an hour trying to repro, I found out that it's using the
span
elements fromlinter-eslint
that it had recycled, and it's passing the same without clearing their class attributeThe text was updated successfully, but these errors were encountered: