Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat internal types: import and re-export PreactElement #3228

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

henryqdineen
Copy link
Contributor

Since PreactElement is used in this module we should also import it instead of only doing the export {} from.

https://github.com/henryqdineen/preact/blob/a1309b8e1a51ee51ca93848d69dc30a5d3ad0356/compat/src/internal.d.ts#L25

I understand that these are just internal types that are used for ts-check but it was just something that I noticed. It seems like it has been innocuous so far. Thanks!

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this was missed and sat for so long

@rschristian rschristian merged commit f0c3e1d into preactjs:main Apr 23, 2024
1 check passed
@coveralls
Copy link

Coverage Status

coverage: 99.605%. remained the same
when pulling cab57f2 on henryqdineen:hqd-compat-types
into e2c8a45 on preactjs:main.

@JoviDeCroock JoviDeCroock mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants