Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hooks calling shouldComponentUpdate without context #3671

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

developit
Copy link
Member

This was breaking code that relies on this within shouldComponentUpdate.

This was breaking code that relies on `this` within shouldComponentUpdate.
@developit developit requested a review from JoviDeCroock August 15, 2022 23:05
@coveralls
Copy link

coveralls commented Aug 15, 2022

Coverage Status

Coverage remained the same at 99.29% when pulling 80de59b on fix-scu-context-hooks into c9ad4f3 on master.

@github-actions
Copy link

github-actions bot commented Aug 15, 2022

Size Change: +27 B (0%)

Total Size: 43.9 kB

Filename Size Change
hooks/dist/hooks.js 1.39 kB +9 B (0%)
hooks/dist/hooks.module.js 1.41 kB +9 B (0%)
hooks/dist/hooks.umd.js 1.48 kB +9 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.72 kB 0 B
compat/dist/compat.module.js 3.7 kB 0 B
compat/dist/compat.umd.js 3.78 kB 0 B
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 3 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 230 B 0 B
devtools/dist/devtools.module.js 239 B 0 B
devtools/dist/devtools.umd.js 306 B 0 B
dist/preact.js 4 kB 0 B
dist/preact.min.js 4.03 kB 0 B
dist/preact.module.js 4.02 kB 0 B
dist/preact.umd.js 4.06 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 444 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 521 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit 4441dc7 into master Aug 16, 2022
@JoviDeCroock JoviDeCroock deleted the fix-scu-context-hooks branch August 16, 2022 08:26
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants