Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typescript definition for class | className #3711

Merged
merged 1 commit into from
Sep 7, 2022
Merged

fix typescript definition for class | className #3711

merged 1 commit into from
Sep 7, 2022

Conversation

PodaruDragos
Copy link
Contributor

@PodaruDragos PodaruDragos commented Sep 5, 2022 •
edited
Loading

When using typescript's exactOptionalPropertyTypes and accessing css-modules with a index definition the class and or className must be typed to string | undefined to appease the compiler.

this fix just modifies those properties to also include undefined, which won't break anything.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.527% when pulling d607d05 on PodaruDragos:FIX/ts-typyes-for-classes into 803dbb5 on preactjs:master.

@JoviDeCroock JoviDeCroock merged commit a5258a9 into preactjs:master Sep 7, 2022
JoviDeCroock added a commit that referenced this pull request Oct 26, 2022
@JoviDeCroock
backport #3711
fbe464c
@deadem deadem mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PodaruDragos @coveralls @JoviDeCroock