Bugfix: don't remove nested DOM elements in unmount

[developit]

No description provided.

[github-actions]

📊 Tachometer Benchmark Results

Summary

duration

• 02_replace1k: unsure 🔍 -5% - +2% (-7.28ms - +2.35ms)
  ^{preact-local vs preact-master}
• 03_update10th1k_x16: slower ❌ 0% - 7% (0.09ms - 2.23ms)
  ^{preact-local vs preact-master}
• 07_create10k: unsure 🔍 -1% - +0% (-17.34ms - +6.86ms)
  ^{preact-local vs preact-master}
• filter_list: unsure 🔍 -5% - +0% (-1.43ms - +0.14ms)
  ^{preact-local vs preact-master}
• hydrate1k: unsure 🔍 -3% - +2% (-3.29ms - +2.41ms)
  ^{preact-local vs preact-master}
• many_updates: unsure 🔍 -2% - +5% (-0.96ms - +2.04ms)
  ^{preact-local vs preact-master}
• text_update: unsure 🔍 -4% - +1% (-0.14ms - +0.05ms)
  ^{preact-local vs preact-master}
• todo: unsure 🔍 -2% - +0% (-0.93ms - +0.25ms)
  ^{preact-local vs preact-master}

usedJSHeapSize

• 02_replace1k: unsure 🔍 -1% - +5% (-0.03ms - +0.17ms)
  ^{preact-local vs preact-master}
• 03_update10th1k_x16: unsure 🔍 -0% - +1% (-0.00ms - +0.03ms)
  ^{preact-local vs preact-master}
• 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-master}
• filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-master}
• hydrate1k: unsure 🔍 -1% - +2% (-0.08ms - +0.15ms)
  ^{preact-local vs preact-master}
• many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-master}
• text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
  ^{preact-local vs preact-master}
• todo: unsure 🔍 -1% - +1% (-0.01ms - +0.01ms)
  ^{preact-local vs preact-master}

Results

02_replace1k

• Browser: chrome-headless 105.0.5195.125
• Sample size: 70
• Built by: Benchmarks #906

• Commit: 6b70436

duration

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	152.93ms - 155.71ms	-	unsure 🔍 -2% - +5% -2.35ms - +7.28ms	unsure 🔍 -3% - +4% -4.01ms - +5.49ms
preact-local	147.24ms - 156.47ms	unsure 🔍 -5% - +2% -7.28ms - +2.35ms	-	unsure 🔍 -5% - +3% -8.20ms - +4.74ms
preact-hooks	149.04ms - 158.12ms	unsure 🔍 -4% - +3% -5.49ms - +4.01ms	unsure 🔍 -3% - +5% -4.74ms - +8.20ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	3.71ms - 3.72ms	-	unsure 🔍 -4% - +1% -0.17ms - +0.03ms	faster ✔ 9% - 12% 0.35ms - 0.50ms
preact-local	3.69ms - 3.88ms	unsure 🔍 -1% - +5% -0.03ms - +0.17ms	-	faster ✔ 6% - 12% 0.24ms - 0.48ms
preact-hooks	4.07ms - 4.22ms	slower ❌ 9% - 14% 0.35ms - 0.50ms	slower ❌ 6% - 13% 0.24ms - 0.48ms	-

run-warmup-0

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	1.29ms - 1.36ms	-	unsure 🔍 -3% - +4% -0.04ms - +0.05ms	unsure 🔍 -9% - +2% -0.12ms - +0.03ms
preact-local	1.29ms - 1.35ms	unsure 🔍 -4% - +3% -0.05ms - +0.04ms	-	unsure 🔍 -9% - +1% -0.13ms - +0.02ms
preact-hooks	1.31ms - 1.45ms	unsure 🔍 -2% - +9% -0.03ms - +0.12ms	unsure 🔍 -1% - +10% -0.02ms - +0.13ms	-

run-warmup-1

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	0.73ms - 1.07ms	-	unsure 🔍 -38% - +11% -0.41ms - +0.13ms	unsure 🔍 -12% - +46% -0.08ms - +0.34ms
preact-local	0.83ms - 1.25ms	unsure 🔍 -17% - +48% -0.13ms - +0.41ms	-	slower ❌ 0% - 70% 0.03ms - 0.51ms
preact-hooks	0.65ms - 0.89ms	unsure 🔍 -35% - +7% -0.34ms - +0.08ms	faster ✔ 7% - 45% 0.03ms - 0.51ms	-

run-warmup-2

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	1.17ms - 1.61ms	-	unsure 🔍 -8% - +44% -0.07ms - +0.50ms	slower ❌ 32% - 98% 0.31ms - 0.79ms
preact-local	1.00ms - 1.36ms	unsure 🔍 -34% - +3% -0.50ms - +0.07ms	-	slower ❌ 13% - 67% 0.13ms - 0.54ms
preact-hooks	0.74ms - 0.95ms	faster ✔ 27% - 51% 0.31ms - 0.79ms	faster ✔ 15% - 42% 0.13ms - 0.54ms	-

run-warmup-3

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	0.45ms - 0.51ms	-	unsure 🔍 -18% - +7% -0.09ms - +0.04ms	faster ✔ 4% - 19% 0.02ms - 0.10ms
preact-local	0.45ms - 0.56ms	unsure 🔍 -8% - +19% -0.04ms - +0.09ms	-	unsure 🔍 -18% - +5% -0.10ms - +0.03ms
preact-hooks	0.52ms - 0.57ms	slower ❌ 3% - 22% 0.02ms - 0.10ms	unsure 🔍 -6% - +19% -0.03ms - +0.10ms	-

run-warmup-4

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	3.62ms - 6.64ms	-	unsure 🔍 -39% - +51% -1.84ms - +2.42ms	slower ❌ 247% - 804% 2.77ms - 5.84ms
preact-local	3.33ms - 6.34ms	unsure 🔍 -46% - +35% -2.42ms - +1.84ms	-	slower ❌ 220% - 759% 2.49ms - 5.55ms
preact-hooks	0.55ms - 1.09ms	faster ✔ 77% - 91% 2.77ms - 5.84ms	faster ✔ 75% - 91% 2.49ms - 5.55ms	-

run-final

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	0.29ms - 0.37ms	-	unsure 🔍 -15% - +23% -0.05ms - +0.07ms	unsure 🔍 -22% - +16% -0.07ms - +0.05ms
preact-local	0.27ms - 0.36ms	unsure 🔍 -22% - +14% -0.07ms - +0.05ms	-	unsure 🔍 -26% - +13% -0.09ms - +0.05ms
preact-hooks	0.29ms - 0.39ms	unsure 🔍 -17% - +23% -0.05ms - +0.07ms	unsure 🔍 -15% - +30% -0.05ms - +0.09ms	-

03_update10th1k_x16

• Browser: chrome-headless 105.0.5195.125
• Sample size: 110
• Built by: Benchmarks #906

• Commit: 6b70436

duration

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	31.34ms - 32.74ms	-	faster ✔ 0% - 7% 0.09ms - 2.23ms	unsure 🔍 -5% - +2% -1.62ms - +0.54ms
preact-local	32.40ms - 34.01ms	slower ❌ 0% - 7% 0.09ms - 2.23ms	-	unsure 🔍 -2% - +5% -0.53ms - +1.78ms
preact-hooks	31.76ms - 33.41ms	unsure 🔍 -2% - +5% -0.54ms - +1.62ms	unsure 🔍 -5% - +2% -1.78ms - +0.53ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	3.73ms - 3.75ms	-	unsure 🔍 -1% - +0% -0.03ms - +0.00ms	faster ✔ 7% - 8% 0.30ms - 0.33ms
preact-local	3.75ms - 3.76ms	unsure 🔍 -0% - +1% -0.00ms - +0.03ms	-	faster ✔ 7% - 8% 0.29ms - 0.32ms
preact-hooks	4.05ms - 4.07ms	slower ❌ 8% - 9% 0.30ms - 0.33ms	slower ❌ 8% - 8% 0.29ms - 0.32ms	-

07_create10k

• Browser: chrome-headless 105.0.5195.125
• Sample size: 50
• Built by: Benchmarks #906

• Commit: 6b70436

duration

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	1794.49ms - 1811.81ms	-	unsure 🔍 -0% - +1% -6.86ms - +17.34ms	faster ✔ 2% - 3% 36.03ms - 63.76ms
preact-local	1789.46ms - 1806.36ms	unsure 🔍 -1% - +0% -17.34ms - +6.86ms	-	faster ✔ 2% - 4% 41.40ms - 68.87ms
preact-hooks	1842.21ms - 1863.87ms	slower ❌ 2% - 4% 36.03ms - 63.76ms	slower ❌ 2% - 4% 41.40ms - 68.87ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	25.52ms - 25.52ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	faster ✔ 9% - 9% 2.55ms - 2.55ms
preact-local	25.52ms - 25.52ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-	faster ✔ 9% - 9% 2.55ms - 2.55ms
preact-hooks	28.07ms - 28.07ms	slower ❌ 10% - 10% 2.55ms - 2.55ms	slower ❌ 10% - 10% 2.55ms - 2.55ms	-

filter_list

• Browser: chrome-headless 105.0.5195.125
• Sample size: 50
• Built by: Benchmarks #906

• Commit: 6b70436

duration

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	30.44ms - 31.74ms	-	unsure 🔍 -0% - +5% -0.14ms - +1.43ms	unsure 🔍 -1% - +5% -0.35ms - +1.42ms
preact-local	30.01ms - 30.89ms	unsure 🔍 -5% - +0% -1.43ms - +0.14ms	-	unsure 🔍 -3% - +2% -0.85ms - +0.63ms
preact-hooks	29.96ms - 31.16ms	unsure 🔍 -5% - +1% -1.42ms - +0.35ms	unsure 🔍 -2% - +3% -0.63ms - +0.85ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	1.75ms - 1.75ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	faster ✔ 13% - 15% 0.26ms - 0.30ms
preact-local	1.75ms - 1.75ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-	faster ✔ 13% - 15% 0.26ms - 0.30ms
preact-hooks	2.01ms - 2.05ms	slower ❌ 15% - 17% 0.26ms - 0.30ms	slower ❌ 15% - 17% 0.26ms - 0.30ms	-

hydrate1k

• Browser: chrome-headless 105.0.5195.125
• Sample size: 70
• Built by: Benchmarks #906

• Commit: 6b70436

duration

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	108.19ms - 112.09ms	-	unsure 🔍 -2% - +3% -2.41ms - +3.29ms	unsure 🔍 -5% - +1% -5.17ms - +0.96ms
preact-local	107.63ms - 111.78ms	unsure 🔍 -3% - +2% -3.29ms - +2.41ms	-	unsure 🔍 -5% - +1% -5.69ms - +0.61ms
preact-hooks	109.88ms - 114.62ms	unsure 🔍 -1% - +5% -0.96ms - +5.17ms	unsure 🔍 -1% - +5% -0.61ms - +5.69ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	6.28ms - 6.41ms	-	unsure 🔍 -2% - +1% -0.15ms - +0.08ms	faster ✔ 13% - 19% 0.91ms - 1.49ms
preact-local	6.29ms - 6.48ms	unsure 🔍 -1% - +2% -0.08ms - +0.15ms	-	faster ✔ 12% - 19% 0.87ms - 1.46ms
preact-hooks	7.27ms - 7.83ms	slower ❌ 14% - 24% 0.91ms - 1.49ms	slower ❌ 14% - 23% 0.87ms - 1.46ms	-

many_updates

• Browser: chrome-headless 105.0.5195.125
• Sample size: 60
• Built by: Benchmarks #906

• Commit: 6b70436

duration

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	41.95ms - 44.04ms	-	unsure 🔍 -5% - +2% -2.04ms - +0.96ms	faster ✔ 10% - 16% 5.02ms - 8.18ms
preact-local	42.46ms - 44.61ms	unsure 🔍 -2% - +5% -0.96ms - +2.04ms	-	faster ✔ 9% - 15% 4.47ms - 7.66ms
preact-hooks	48.41ms - 50.78ms	slower ❌ 11% - 19% 5.02ms - 8.18ms	slower ❌ 10% - 18% 4.47ms - 7.66ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	4.81ms - 4.82ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	faster ✔ 8% - 8% 0.45ms - 0.45ms
preact-local	4.81ms - 4.82ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-	faster ✔ 8% - 9% 0.45ms - 0.45ms
preact-hooks	5.26ms - 5.26ms	slower ❌ 9% - 9% 0.45ms - 0.45ms	slower ❌ 9% - 9% 0.45ms - 0.45ms	-

text_update

• Browser: chrome-headless 105.0.5195.125
• Sample size: 60
• Built by: Benchmarks #906

• Commit: 6b70436

duration

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	3.30ms - 3.48ms	-	unsure 🔍 -1% - +4% -0.05ms - +0.14ms	faster ✔ 5% - 11% 0.19ms - 0.41ms
preact-local	3.30ms - 3.39ms	unsure 🔍 -4% - +1% -0.14ms - +0.05ms	-	faster ✔ 7% - 11% 0.27ms - 0.42ms
preact-hooks	3.62ms - 3.76ms	slower ❌ 5% - 12% 0.19ms - 0.41ms	slower ❌ 8% - 13% 0.27ms - 0.42ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	0.98ms - 0.98ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	faster ✔ 2% - 2% 0.01ms - 0.01ms
preact-local	0.98ms - 0.98ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-	faster ✔ 1% - 1% 0.01ms - 0.01ms
preact-hooks	1.00ms - 1.00ms	slower ❌ 2% - 2% 0.01ms - 0.01ms	slower ❌ 2% - 2% 0.01ms - 0.01ms	-

todo

• Browser: chrome-headless 105.0.5195.125
• Sample size: 90
• Built by: Benchmarks #906

• Commit: 6b70436

duration

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	52.42ms - 53.58ms	-	unsure 🔍 -0% - +2% -0.25ms - +0.93ms	faster ✔ 3% - 5% 1.43ms - 2.63ms
preact-local	52.53ms - 52.79ms	unsure 🔍 -2% - +0% -0.93ms - +0.25ms	-	faster ✔ 4% - 5% 2.17ms - 2.58ms
preact-hooks	54.88ms - 55.19ms	slower ❌ 3% - 5% 1.43ms - 2.63ms	slower ❌ 4% - 5% 2.17ms - 2.58ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local	vs preact-hooks
preact-master	1.38ms - 1.39ms	-	unsure 🔍 -1% - +1% -0.01ms - +0.01ms	slower ❌ 4% - 6% 0.05ms - 0.08ms
preact-local	1.38ms - 1.40ms	unsure 🔍 -1% - +1% -0.01ms - +0.01ms	-	slower ❌ 4% - 6% 0.05ms - 0.08ms
preact-hooks	1.30ms - 1.33ms	faster ✔ 4% - 6% 0.05ms - 0.08ms	faster ✔ 4% - 6% 0.05ms - 0.08ms	-

_{tachometer-reporter-action v2 for Benchmarks}

[github-actions]

Size Change: +15 B (0%)

Total Size: 52.9 kB

Filename	Size	Change
dist/preact.js	4.03 kB	+3 B (0%)
dist/preact.min.js	4.05 kB	+3 B (0%)
dist/preact.min.module.js	4.05 kB	+2 B (0%)
dist/preact.min.umd.js	4.08 kB	+3 B (0%)
dist/preact.module.js	4.04 kB	+3 B (0%)
dist/preact.umd.js	4.09 kB	+1 B

ℹ️ View Unchanged

Filename	Size	Change
compat/dist/compat.js	3.78 kB	0 B
compat/dist/compat.module.js	3.72 kB	0 B
compat/dist/compat.umd.js	3.85 kB	0 B
debug/dist/debug.js	3.01 kB	0 B
debug/dist/debug.module.js	3.01 kB	0 B
debug/dist/debug.umd.js	3.09 kB	0 B
devtools/dist/devtools.js	231 B	0 B
devtools/dist/devtools.module.js	239 B	0 B
devtools/dist/devtools.umd.js	314 B	0 B
hooks/dist/hooks.js	1.56 kB	0 B
hooks/dist/hooks.module.js	1.59 kB	0 B
hooks/dist/hooks.umd.js	1.64 kB	0 B
jsx-runtime/dist/jsxRuntime.js	358 B	0 B
jsx-runtime/dist/jsxRuntime.module.js	324 B	0 B
jsx-runtime/dist/jsxRuntime.umd.js	439 B	0 B
test-utils/dist/testUtils.js	442 B	0 B
test-utils/dist/testUtils.module.js	444 B	0 B
test-utils/dist/testUtils.umd.js	526 B	0 B

_{compressed-size-action}

[coveralls]

Coverage remained the same at 99.527% when pulling 6b70436 on bugfix-nested-unmount into a868b02 on master.