Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set dimensional attributes through setAttribute #3888

Merged
merged 5 commits into from
Feb 9, 2023
Merged

set dimensional attributes through setAttribute #3888

merged 5 commits into from
Feb 9, 2023

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Feb 7, 2023 •
edited
Loading

Fixes #3887

This also uncovered another bug, when we pass px values to these properties it fails to set them as well

@github-actions
Copy link

github-actions bot commented Feb 7, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

  • 02_replace1k: unsure 🔍 -0% - +2% (-0.72ms - +2.50ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -3% - +4% (-1.51ms - +2.45ms)
    preact-local vs preact-master
  • 07_create10k: slower ❌ 0% - 1% (1.35ms - 16.52ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -3% - +1% (-0.59ms - +0.34ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -5% - +1% (-6.23ms - +1.74ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -2% - +2% (-0.54ms - +0.63ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +2% (-0.03ms - +0.06ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -1% - +1% (-0.42ms - +0.61ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -1% - +3% (-0.03ms - +0.10ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +1% (-0.02ms - +0.20ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +1% (-0.02ms - +0.03ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

⏳ Benchmarks are currently running. Results below are out of date.
02_replace1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master147.10ms - 149.19ms-unsure 🔍
-2% - +0%
-2.50ms - +0.72ms		faster ✔
1% - 3%
1.68ms - 4.79ms
preact-local147.81ms - 150.26msunsure 🔍
-0% - +2%
-0.72ms - +2.50ms		-faster ✔
0% - 3%
0.66ms - 4.02ms
preact-hooks150.23ms - 152.53msslower ❌
1% - 3%
1.68ms - 4.79ms		slower ❌
0% - 3%
0.66ms - 4.02ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.38ms - 3.39ms-unsure 🔍
-3% - +1%
-0.10ms - +0.03ms		faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local3.35ms - 3.49msunsure 🔍
-1% - +3%
-0.03ms - +0.10ms		-unsure 🔍
-2% - +2%
-0.06ms - +0.08ms
preact-hooks3.41ms - 3.42msslower ❌
1% - 1%
0.02ms - 0.03ms		unsure 🔍
-2% - +2%
-0.08ms - +0.06ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master51.64ms - 54.74ms-unsure 🔍
-5% - +2%
-2.61ms - +1.34ms		unsure 🔍
-7% - +1%
-3.85ms - +0.32ms
preact-local52.60ms - 55.05msunsure 🔍
-3% - +5%
-1.34ms - +2.61ms		-unsure 🔍
-5% - +1%
-2.98ms - +0.72ms
preact-hooks53.57ms - 56.35msunsure 🔍
-1% - +7%
-0.32ms - +3.85ms		unsure 🔍
-1% - +6%
-0.72ms - +2.98ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master68.55ms - 71.69ms-unsure 🔍
-4% - +3%
-2.92ms - +1.95ms		faster ✔
1% - 6%
0.49ms - 4.64ms
preact-local68.75ms - 72.47msunsure 🔍
-3% - +4%
-1.95ms - +2.92ms		-unsure 🔍
-6% - +0%
-4.38ms - +0.23ms
preact-hooks71.33ms - 74.04msslower ❌
1% - 7%
0.49ms - 4.64ms		unsure 🔍
-0% - +6%
-0.23ms - +4.38ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master54.02ms - 57.37ms-unsure 🔍
-7% - +1%
-4.19ms - +0.61ms		slower ❌
1% - 9%
0.32ms - 4.60ms
preact-local55.77ms - 59.20msunsure 🔍
-1% - +8%
-0.61ms - +4.19ms		-slower ❌
4% - 12%
2.08ms - 6.42ms
preact-hooks51.90ms - 54.57msfaster ✔
1% - 8%
0.32ms - 4.60ms		faster ✔
4% - 11%
2.08ms - 6.42ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master44.39ms - 46.03ms-unsure 🔍
-4% - +1%
-1.77ms - +0.63ms		faster ✔
2% - 7%
0.85ms - 3.23ms
preact-local44.90ms - 46.65msunsure 🔍
-1% - +4%
-0.63ms - +1.77ms		-faster ✔
1% - 6%
0.24ms - 2.70ms
preact-hooks46.38ms - 48.11msslower ❌
2% - 7%
0.85ms - 3.23ms		slower ❌
0% - 6%
0.24ms - 2.70ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master45.72ms - 47.35ms-unsure 🔍
-6% - +1%
-2.72ms - +0.35ms		faster ✔
4% - 9%
1.85ms - 4.66ms
preact-local46.41ms - 49.01msunsure 🔍
-1% - +6%
-0.35ms - +2.72ms		-faster ✔
1% - 8%
0.34ms - 3.81ms
preact-hooks48.65ms - 50.93msslower ❌
4% - 10%
1.85ms - 4.66ms		slower ❌
1% - 8%
0.34ms - 3.81ms		-

run-final

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master33.01ms - 33.75ms-unsure 🔍
-4% - +0%
-1.29ms - +0.01ms		unsure 🔍
-2% - +0%
-0.74ms - +0.03ms
preact-local33.49ms - 34.56msunsure 🔍
-0% - +4%
-0.01ms - +1.29ms		-unsure 🔍
-1% - +2%
-0.27ms - +0.83ms
preact-hooks33.62ms - 33.86msunsure 🔍
-0% - +2%
-0.03ms - +0.74ms		unsure 🔍
-2% - +1%
-0.83ms - +0.27ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master58.03ms - 60.80ms-unsure 🔍
-4% - +3%
-2.45ms - +1.51ms		unsure 🔍
-2% - +5%
-1.18ms - +2.70ms
preact-local58.47ms - 61.31msunsure 🔍
-3% - +4%
-1.51ms - +2.45ms		-unsure 🔍
-1% - +5%
-0.73ms - +3.20ms
preact-hooks57.30ms - 60.01msunsure 🔍
-5% - +2%
-2.70ms - +1.18ms		unsure 🔍
-5% - +1%
-3.20ms - +0.73ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.28ms - 3.29ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
0% - 1%
0.01ms - 0.02ms
preact-local3.28ms - 3.29msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.30ms - 3.31msslower ❌
0% - 1%
0.01ms - 0.02ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1387.34ms - 1397.68ms-faster ✔
0% - 1%
1.35ms - 16.52ms		faster ✔
0% - 1%
5.63ms - 20.07ms
preact-local1395.89ms - 1406.99msslower ❌
0% - 1%
1.35ms - 16.52ms		-unsure 🔍
-1% - +0%
-11.42ms - +3.58ms
preact-hooks1400.32ms - 1410.40msslower ❌
0% - 1%
5.63ms - 20.07ms		unsure 🔍
-0% - +1%
-3.58ms - +11.42ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master25.36ms - 25.36ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local25.36ms - 25.36msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks25.38ms - 25.38msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master22.81ms - 23.56ms-unsure 🔍
-1% - +3%
-0.34ms - +0.59ms		unsure 🔍
-1% - +3%
-0.22ms - +0.63ms
preact-local22.78ms - 23.33msunsure 🔍
-3% - +1%
-0.59ms - +0.34ms		-unsure 🔍
-1% - +2%
-0.25ms - +0.42ms
preact-hooks22.78ms - 23.17msunsure 🔍
-3% - +1%
-0.63ms - +0.22ms		unsure 🔍
-2% - +1%
-0.42ms - +0.25ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.61ms - 1.61ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 2%
0.02ms - 0.03ms
preact-local1.61ms - 1.61msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 2%
0.02ms - 0.03ms
preact-hooks1.63ms - 1.64msslower ❌
1% - 2%
0.02ms - 0.03ms		slower ❌
1% - 2%
0.02ms - 0.03ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master119.91ms - 125.59ms-unsure 🔍
-1% - +5%
-1.74ms - +6.23ms		unsure 🔍
-2% - +4%
-2.49ms - +5.26ms
preact-local117.71ms - 123.30msunsure 🔍
-5% - +1%
-6.23ms - +1.74ms		-unsure 🔍
-4% - +2%
-4.70ms - +2.98ms
preact-hooks118.73ms - 124.00msunsure 🔍
-4% - +2%
-5.26ms - +2.49ms		unsure 🔍
-2% - +4%
-2.98ms - +4.70ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master18.19ms - 18.40ms-unsure 🔍
-1% - +0%
-0.20ms - +0.02ms		faster ✔
0% - 1%
0.03ms - 0.25ms
preact-local18.35ms - 18.42msunsure 🔍
-0% - +1%
-0.02ms - +0.20ms		-faster ✔
0% - 1%
0.00ms - 0.09ms
preact-hooks18.40ms - 18.46msslower ❌
0% - 1%
0.03ms - 0.25ms		slower ❌
0% - 1%
0.00ms - 0.09ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master28.73ms - 29.59ms-unsure 🔍
-2% - +2%
-0.63ms - +0.54ms		faster ✔
0% - 4%
0.06ms - 1.22ms
preact-local28.81ms - 29.60msunsure 🔍
-2% - +2%
-0.54ms - +0.63ms		-faster ✔
0% - 4%
0.05ms - 1.14ms
preact-hooks29.42ms - 30.18msslower ❌
0% - 4%
0.06ms - 1.22ms		slower ❌
0% - 4%
0.05ms - 1.14ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.58ms - 4.62ms-unsure 🔍
-1% - +0%
-0.03ms - +0.02ms		faster ✔
1% - 2%
0.04ms - 0.08ms
preact-local4.59ms - 4.63msunsure 🔍
-0% - +1%
-0.02ms - +0.03ms		-faster ✔
1% - 2%
0.04ms - 0.08ms
preact-hooks4.66ms - 4.67msslower ❌
1% - 2%
0.04ms - 0.08ms		slower ❌
1% - 2%
0.04ms - 0.08ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master2.95ms - 3.01ms-unsure 🔍
-2% - +1%
-0.06ms - +0.03ms		faster ✔
2% - 13%
0.06ms - 0.44ms
preact-local2.97ms - 3.03msunsure 🔍
-1% - +2%
-0.03ms - +0.06ms		-faster ✔
2% - 13%
0.04ms - 0.42ms
preact-hooks3.04ms - 3.42msslower ❌
2% - 15%
0.06ms - 0.44ms		slower ❌
1% - 14%
0.04ms - 0.42ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.82ms - 0.82ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		faster ✔
1% - 2%
0.01ms - 0.01ms
preact-local0.82ms - 0.82msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-faster ✔
1% - 2%
0.01ms - 0.01ms
preact-hooks0.83ms - 0.83msslower ❌
1% - 2%
0.01ms - 0.01ms		slower ❌
1% - 2%
0.01ms - 0.01ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master54.43ms - 54.91ms-unsure 🔍
-1% - +1%
-0.61ms - +0.42ms		faster ✔
3% - 4%
1.67ms - 2.56ms
preact-local54.31ms - 55.22msunsure 🔍
-1% - +1%
-0.42ms - +0.61ms		-faster ✔
3% - 5%
1.43ms - 2.61ms
preact-hooks56.41ms - 57.16msslower ❌
3% - 5%
1.67ms - 2.56ms		slower ❌
3% - 5%
1.43ms - 2.61ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.09ms - 1.09ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
2% - 2%
0.02ms - 0.03ms
preact-local1.09ms - 1.09msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 2%
0.02ms - 0.02ms
preact-hooks1.11ms - 1.12msslower ❌
2% - 2%
0.02ms - 0.03ms		slower ❌
2% - 2%
0.02ms - 0.02ms		-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

coveralls commented Feb 7, 2023 •
edited
Loading

Coverage Status

Coverage: 98.933% (-0.6%) from 99.543% when pulling d899499 on dimensional-image into 233eaef on master.

jpnelson
jpnelson approved these changes Feb 7, 2023
View reviewed changes
Copy link

@jpnelson jpnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think this would do the trick!

@github-actions
Copy link

github-actions bot commented Feb 7, 2023 •
edited
Loading

Size Change: +69 B (0%)

Total Size: 54 kB

Filename Size Change
dist/preact.js 4.23 kB +12 B (0%)
dist/preact.min.js 4.26 kB +12 B (0%)
dist/preact.min.module.js 4.25 kB +11 B (0%)
dist/preact.min.umd.js 4.28 kB +11 B (0%)
dist/preact.module.js 4.24 kB +13 B (0%)
dist/preact.umd.js 4.3 kB +10 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.81 kB 0 B
compat/dist/compat.module.js 3.75 kB 0 B
compat/dist/compat.umd.js 3.87 kB 0 B
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 3.01 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
hooks/dist/hooks.js 1.49 kB 0 B
hooks/dist/hooks.module.js 1.52 kB 0 B
hooks/dist/hooks.umd.js 1.57 kB 0 B
jsx-runtime/dist/jsxRuntime.js 360 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 326 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 441 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action

@JoviDeCroock
Copy link
Member Author

The regex doesn't really save bytes so I will revert it

@JoviDeCroock JoviDeCroock merged commit 9b83481 into master Feb 9, 2023
@JoviDeCroock JoviDeCroock deleted the dimensional-image branch February 9, 2023 05:59
JoviDeCroock added a commit that referenced this pull request Jan 12, 2024
@JoviDeCroock
backport #3888
6da1922
JoviDeCroock added a commit that referenced this pull request Jan 12, 2024
@JoviDeCroock
chore: backport 10.12.x to v11 (#4255)
36ef4e8 
* backport #3871

* port test from #3884 functionality seems to work in v11

* backport #3880

* backport #3875

* backport #3862

* add todo for #3801

* backport #3868

* backport #3867

* backport #3863

* add todo for #3856

* backport #3844

* backport #3816

* backport #3888

* backport #3889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpnelson jpnelson jpnelson approved these changes

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Images with width=100% don't client side render correctly
4 participants
@JoviDeCroock @coveralls @marvinhagemeister @jpnelson