Fix hydrating textarea with value prop #3891
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a component rendered
<textarea value="Test" />
, on the server we'd render<textarea>Test</textarea>
, but on the client when hydrating, we'd remove the children of<textarea>
since the component didn't specify any (textarea value="test" />
). Further, since we don't set attributes or properties on hydration, the value property doesn't get applied either.This PR fixes this behavior by adding a new hook to compat which checks if the VNode is a textarea and always applying the
value
if the DOM value doesn't match.