Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isNaN helper for IE11 #3981

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Add isNaN helper for IE11 #3981

merged 1 commit into from
Apr 22, 2023

Conversation

andrewiggins
Copy link
Member

@andrewiggins andrewiggins commented Apr 22, 2023

According to our Saucelabs tests, IE11 doesn't support Number.isNaN so I've added a littler helper to use instead.

Also fixed some quotes in one of our npm scripts so it works correctly on Windows

@github-actions
Copy link

Size Change: +1 B

Total Size: 56.6 kB

Filename Size Change
debug/dist/debug.module.js 3.52 kB +1 B
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 4.07 kB 0 B
compat/dist/compat.module.js 4 kB 0 B
compat/dist/compat.umd.js 4.13 kB 0 B
debug/dist/debug.js 3.53 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 315 B 0 B
dist/preact.js 4.25 kB 0 B
dist/preact.min.js 4.28 kB 0 B
dist/preact.min.module.js 4.28 kB 0 B
dist/preact.min.umd.js 4.31 kB 0 B
dist/preact.module.js 4.28 kB 0 B
dist/preact.umd.js 4.32 kB 0 B
hooks/dist/hooks.js 1.53 kB 0 B
hooks/dist/hooks.module.js 1.56 kB 0 B
hooks/dist/hooks.umd.js 1.61 kB 0 B
jsx-runtime/dist/jsxRuntime.js 360 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 326 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 441 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action

@github-actions
Copy link

Coverage Status

Coverage: 99.706%. Remained the same when pulling 70e3e76 on fix-ie11-tests into 7adb147 on master.

@andrewiggins andrewiggins merged commit 6cc8688 into master Apr 22, 2023
@andrewiggins andrewiggins deleted the fix-ie11-tests branch April 22, 2023 22:05
@JoviDeCroock JoviDeCroock mentioned this pull request May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants