Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TS FunctionComponent w/ exactOptionalPropertyTypes #4025

Merged
merged 2 commits into from
May 25, 2023

Conversation

rschristian
Copy link
Member

@rschristian rschristian commented May 23, 2023

Fixes #4024

It looks like we need to do a #3868 over every optional property.... might do it tomorrow if I get bored at work. This will at least fix the inconsistency causing the linked issue.

@coveralls
Copy link

coveralls commented May 23, 2023

Coverage Status

Coverage: 99.705%. Remained the same when pulling 88c03e5 on fix/ts-forward-ref-exotic into bd593c4 on master.

@rschristian rschristian marked this pull request as draft May 24, 2023 03:18
@rschristian rschristian marked this pull request as ready for review May 25, 2023 22:32
@rschristian rschristian merged commit fb8cfa9 into master May 25, 2023
@rschristian rschristian deleted the fix/ts-forward-ref-exotic branch May 25, 2023 22:37
@JoviDeCroock JoviDeCroock mentioned this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preact@10.15.0 newly doesn't compile with TypeScript exactOptionalPropertyTypes
4 participants